fix(cosmetics): fvm has one newline too much #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonasbadstuebner is attempting to deploy a commit to the FlutterTools Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, first of all: Thank you very much for your work with fvm! I really really love the tool and if I have improvements for the future, I am going to contribute and try to help that way!
I was facing a very annoying and draining issue that occurred after reinstalling my laptop, which was that I could not generate protobuffers for dart anymore.
I was pulling my hair out trying to understand, what was happening. And now I found the issue, you can see it in the changes of this PR.
I am wondering if you had any special use case why this extra newline was needed. If you ask me, FVM should not alter the output of at least the dart calls, as to not break compatibility with tools that are developed against plain dart, like in my case.
FVM should be a seamless wrapper and therefore not add this newline.
I could not find a FVM command that looks weird if this newline is not added, so please let me know why you added it?
Otherwise I would very much appreciate it, if it could be removed. Because then I don't have to break my back trying to get protoc to work while still using FVM.
The issues I opened already, but were nowhere close to the real source of the problem, are the following: