Starlette v0.26.0 support and authorize_redirect fix #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starlette
0.26.0
changed the return value ofurl_for()
fromstr
toURL
; see encode/starlette#1385 for context.Passing a
redirect_uri
toauthorize_redirect
causes aTypeError: cannot convert 'URL' object to bytes
exception to be raised if the URL has been generated viaurl_for()
. This fix detects an instance ofURL
and casts it to a string, thus allowing authentication to proceed and generally making people happy.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)