-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR - FollowLink in horizontal split #223
Comments
Thanks for the suggestion. I fully agree. In fact, I think it could be possible to simplify and make a single command that takes a modifier to allow splitting. I'll look into it! |
Ok, so, I changed the default to a normal :WikiLinkFollowSplit " follow in regular split
:vertical WikiLinkFollowSplit " follow in vertical split
:topleft vertical WikiLinkFollowSplit " follow in vertical split on left side I hope this matches your requested feature! |
Sorry I did not check my email for a couple of days. Thank you very much for handling it so quickly, I will check it out tomorrow when I get back to my notes. 👍 |
My pleasure; let me know if you have other suggestion/issues! |
Hi, I tried your update, and modified my config accordingly, and everything works fine, as expected. I do not think it is worth reopening an issue, but I believe it is worth mentioning. The only small down side I find about the implementation you went with, is that there is no I personally set up an It is also possible that I am mistaken, in which case, I would gladly learn how to make it work using the Either way, thank you again for your time. |
Ah, good point. I believe it is worth adding a new mapping for this and have both a normal split and a vertical split. Both can use the same command. |
I pushed an update for this. One thing: what would be considered good defaults mappings here? I've kept |
To be honest, I am myself still experimenting to settle on a key mapping for the new To me, I personally use I am sorry I could not be of more help, and, I will let you know if I get a stronger opinion on that matter. In the meantime, thank you again for adding yet another enhancement so quickly. |
Ok, thanks for sharing your thoughts. I think the most important thing is that one can disable all the default mappings and/or change any of them with relatively simple customization. Thus, we don't really need optimal defaults. I might change the defaults if I can decide on something I think is "objectively" better, but in the meantime, I'm happy with the current version. |
I totally agree, optimal defaults are very subjective anyway. You offer sane defaults, and the freedom to modify them easily with an exhaustive documentation, I believe this is all that is needed to make any other vim user happy as well. 👍 |
I am sorry if I missed something in the
help
, but I cannot find a command to follow a link in a horizontal split, only in a vertical one. I personally want to use vertical splits most of the time, but sometimes, I would find it useful to have more notes / windows open and visible.Thank you for your time, and this cool plugin.
The text was updated successfully, but these errors were encountered: