Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small compatibility fix for prototype.js #1804

Merged
merged 1 commit into from
Jan 14, 2014
Merged

Conversation

kemaldaggen
Copy link
Contributor

for (var i in array) loop is causing errors when using less.watch(), this converts loop into standart numerical indexed for loop, so that using less.js with pages that also uses prototype.js would not cause any errors of the following kind:

"name[k].charAt is not a function"

lukeapage added a commit that referenced this pull request Jan 14, 2014
small compatibility fix for prototype.js
@lukeapage lukeapage merged commit 0bc82a4 into less:master Jan 14, 2014
@lukeapage
Copy link
Member

damn, we switched on jshint and I thought we caught all the in cases.

@lukeapage
Copy link
Member

searched manually for " in " it seems this was the only place we missed. does it completely break when used with prototype? guess you'll want a new release soon.. ?

@kemaldaggen
Copy link
Contributor Author

thanks. No we do not require any release, we are going for the version we fixed. It works initialy, but when you start watch and change less file, than it immediately breaks because of prototype.js pollution of a lot of native javascript objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants