Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jit-grunt to the build chain #2488

Merged
merged 4 commits into from
Mar 3, 2015
Merged

Conversation

bassjobsen
Copy link
Contributor

@@ -320,7 +320,7 @@ module.exports = function (grunt) {
});

// Load these plugins to provide the necessary tasks
require('matchdep').filterDev('grunt-*').forEach(grunt.loadNpmTasks);
require('matchdep').filterDev('grunt-*').forEach(require('jit-grunt')(grunt));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the point to remove the matchdep dependency and replace this whole line with
require('jit-grunt')(grunt); ?
I'm fine with that.. but at the moment this code is longer than the replaced code

@bassjobsen
Copy link
Contributor Author

i think you are right, thanks. i removed matchdep

lukeapage added a commit that referenced this pull request Mar 3, 2015
add jit-grunt to the build chain
@lukeapage lukeapage merged commit b3e0657 into less:master Mar 3, 2015
@bassjobsen bassjobsen deleted the jit-grunt branch March 3, 2015 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants