Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of Less to ES6 w/ TypeScript type linting support #3411

Merged
merged 17 commits into from
Aug 3, 2019

Conversation

matthew-dean
Copy link
Member

@matthew-dean matthew-dean commented Aug 2, 2019

  • Converted to ES2015 code using lebab, then replaced browserify with a Rollup build.
  • TypeScript is added to the ESLint parser. The idea is that you can add types (in JSDoc) to verify that it's working. However, the transpiler is still Babel at the moment, so type violations won't throw errors (yet). There was concern some time ago about converting the codebase 100% to TypeScript, but I figured we could get the best of both worlds by keeping it technically JS, but getting compile-time type verification to catch potential errors.
  • I removed the deprecated ieCompat option and the affected code. That was already false by default on 3.0+, but additionally, we weren't testing/supporting IE8 as a browser, so it no longer had any value.

@matthew-dean matthew-dean changed the title Conversion of Less to ES6 w/ TypeScript type support Conversion of Less to ES6 w/ TypeScript type linting support Aug 2, 2019
@matthew-dean matthew-dean merged commit cae5021 into less:master Aug 3, 2019
@matthew-dean matthew-dean deleted the lebab branch August 3, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant