-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added @media bubbling/nesting/merging (similar to SASS) #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sirlantis That looks really useful. I'm looking forward to using this. |
Updated pull-request description to include infos on the last two commits (which add media-query condition merging). |
Note: Using nested |
Very cool. |
+1, very useful |
cloudhead
pushed a commit
that referenced
this pull request
Feb 28, 2012
Add @media bubbling/nesting/merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mentioned in #286 and #152. It would be nice if the following conversion could be made by Less:
This makes it easy to add media-specific styles without having to repeat selectors or break the flow of the stylesheet (quoted from SASS reference).
In 936ab7d I separated Media from Directive and added an algorithm which merges media-queries (also similar to SASS).
Note: A nested media-query will always be forced after the top-level media-query. In the following example the header AND the footer will be black iff a and b.