Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix codecov #743

Open
lestrrat opened this issue May 17, 2022 · 3 comments
Open

[chore] Fix codecov #743

lestrrat opened this issue May 17, 2022 · 3 comments
Assignees
@lestrrat
Labels
good first issue long-term

Comments

@lestrrat
Copy link
Collaborator

After we shuffled around the branches, codecov isn't working as expected.
I'm sure this is something silly, but I personally am not that into the code coverage game and don't feel like spending time on it. It would be nice if someone knowledgeable can give me a hand.
@thomasrockhu-codecov
Copy link

@lestrrat, Tom from Codecov here. I noticed two things

  1. The Codecov GitHub app needs to be installed
  2. The default branch (develop/v2?) is not being set here

@lestrrat
Copy link
Collaborator Author

OMG, I didn't expect somebody from codecov to jump in so fast! (egosurfing much? :)
Thank you very much, and let me check your suggestions

@thomasrockhu-codecov
Copy link

Ha! Something something slack integration 🤷‍♂️. Let me know if that doesn't work for you!

imirkin added a commit to imirkin/jwx that referenced this issue Jul 19, 2022
@imirkin
codecov: update to v3 action
ea29781 
v1 is deprecated and no longer works. Update to v3.

Fixes lestrrat-go#743
@imirkin imirkin mentioned this issue Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lestrrat lestrrat

Labels
good first issue long-term
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP codecov: update to v3 action imirkin/jwx
2 participants
@lestrrat @thomasrockhu-codecov