[P2P] unit with latest build not receiving values of shared plugins

[chromoxdor]

@TD-er if i remember correctly, you recently made changes in the P2P code.
I compiled myself a fresh ESPeasy (Build: ESP_Easy_mega_20230626_normal_ESP8266_4M1M Jun 26 2023).
It shows the plugins shared by other nodes but the values are always zero.
Just that you know....

Edit:
For the context: I have a network of nodes sharing successfully plugins and values for a long time ... its only the new one that doesn´t want to receive.

[chromoxdor]

Hmm..just shared from my oldest node... that seems to work. strange

[TD-er]

That's really strange as I am working on that code right now to optimize it and as far as I know it wasn't broken when I started working on this code 2 days ago.

Can you check with the code of this PR: #4354
?

[chromoxdor]

Can you check with the code of this PR: #4354

no luck..
I tried a slightly older build i had lying around which works fine: (Build: ESP_Easy_mega_20230427_normal_ESP8266_4M1M Apr 27 2023)

[TD-er]

I know there was a bug in one of the builds, but the before last build was working fine again between new and old builds again.
And I do have it working here between nodes running builds I made today and builds with 80+ days uptime. (built on 20230405)

[chromoxdor]

just tried also Build: ESP_Easy_mega_20230508_normal_ESP8266_4M1M May 8 2023
this already doesn´t work

[TD-er]

And which build is on 'the other end' sending the p2p data?

[chromoxdor]

these do not work with the newest build:
ESP_Easy_mega_20220718_custom_IR_ESP8266_1M Jul 18 2022
ESP_Easy_mega_20221015_custom_ESP8266_4M1M Oct 15 2022

this one does:
ESP_Easy_mega_20211105_normal_ESP8266_1M Nov 5 2021

[chromoxdor]

this works too:
ESP_Easy_mega_20201023_normal_ESP8266_1M
🙂

[chromoxdor]

it seems that the issue started somewhere between 11.2021 and 10.2022

[TD-er]

Very strange....
The reason of the other bug was when I added the code for those additional integer types for Dummy tasks (e.g. to store 4x 32bit int, 2x 64 bit int, 2x double, etc)
And that was added this year.

Are you using anything specific? Like different nr of tasks?

[chromoxdor]

Are you using anything specific? Like different nr of tasks?

No, nothing i can think of…

[TD-er]

Double check you have not used unit ID 0, nor 255
Also make sure UDP port 8266 (or whatever port you're using) is the same
Maybe perform an extra save on the sending and/or receiving task

What specific plugins are you using?
Maybe some are using NaN values and I think I've seen some checks for valid values...

[chromoxdor]

ids and udp port are correct.
i up and downgraded one existing node and used a new one for verification. as soon as i upgraded to the newest build values became 0 and when downgrading again it worked

What specific plugins are you using?

Plugins for: dht22, bme280 and just for testing i used the internal analog plugin.

You could try to recreate it by installing one of the above mentioned builds on one device…

[TD-er]

I have units sharing the sysinfo data among them as this seemed a nice test since it doesn't need any hardware to be connected.

[chromoxdor]

didn’t think of the sysinfo plugin but the analog plugin reading noise worked also for me.

[TD-er]

Proof to show it is working.

[chromoxdor]

I am happy to see that it is working with recent builds. But i also never questioned that. I guess i have to do an updateweekend (easier would actually be to downgrade the one new device 😁) to make things work again…

[TD-er]

It is with the same code as from which you concluded it wasn't working.... as it is the same code as on the PR I linked.

[chromoxdor]

Ok i give up.. i tested today different older releases as sender and the latest build as receiver. It works fine!
It seems my custom builds are the issue. I don´t understand why. They are able to send and receive data to each other and to releases before 05.2023 but not to a recent build. Thats really weird since the only addition i made was the color code to rules...

I will close this as it seems to be a very individual issue which hopefully can be solved by updating my devices.

Edit:
Here some pictures to prove it :)

[TD-er]

Like I said, for plugins other than sysinfo there might be a recently added check to see if the data is "valid" and it might not be for all plugins (e.g. when a NaN is set, maybe other reasons too...)
So if the sysinfo cannot be sent between old and new builds, then it probably is some weird build issue.
Otherwise it may still be a bug.

[chromoxdor]

So if the sysinfo cannot be sent between old and new builds,

Unfortunately all my customs builds have in common that they lack the sysinfo plugin. :)
But i unsuccessfully tried a dummy device instead and fed it with values through taskvalueset.

then it probably is some weird build issue.

jup...

[chromoxdor]

@TD-er
Sometimes the most obvious thing to do it the easiest to forget...

There is this thing called "log":

🤦‍♂️
What does it mean?

Edit: This is what i am getting on the node with the new build trying to get data from one with an "old" release

[TD-er]

Ah maybe that's too strict...
I have added a check to see what plugin was sending the data, so the received data would make sense.
Thus having local and remote use the same plugin ID (e.g. P004 for Dallas 1-wire)

But when it has "255" as value (or 0 ???) it is clearly not set at the remote end, thus older firmware
I will make this check a bit more relaxed.

[TD-er]

In src/Globals/Plugins.cpp
Change this function into:

Edit2: Removed suggested code change, see next post.

Edit:
This is just a quick 'fix' to test this, not sure if it will be the final fix as this restricts the use of plugin ID 255.
So I might want to 'patch' the received data from older p2p nodes as we do know the build they are running.

[TD-er]

OK, better fix: (thus undo the previous changes if already done)

bool C013_SensorDataStruct::matchesPluginID(pluginID_t pluginID) const
{
  if (deviceNumber == 255 || !validPluginID(deviceNumber) || !validPluginID(pluginID)) {
    // Was never set, so probably received data from older node.
    return true;
  }
  return pluginID == deviceNumber;
}

[chromoxdor]

Change this function into:
OK, better fix:

Where am i supposed to put this or what should i change?

[TD-er]

This is in src/DataStructs/C013_p2p_dataStruct.cpp
Around line 34 there is already this function, so I just added deviceNumer == 255 ||

[chromoxdor]

not quite the fix..

[chromoxdor]

ich also changed this:

bool C013_SensorDataStruct::matchesSensorType(Sensor_VType sensor_type) const
{
  if (deviceNumber == 255 || sensorType == Sensor_VType::SENSOR_TYPE_NONE) {
    // Was never set, so probably received data from older node.
    return true;
  }
  return sensorType == sensor_type;
}

now it works

[TD-er]

Check!
Will make a commit for it to fix this.