-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision commands, are they removed from the custom builds? #4941
Comments
You can add |
Tried that, didn't help I am on ESP32-C3 now |
The current Custom-sample.h mentions that also |
Yes, I have that enabled as per template |
Ah, it seems that you get LIMIT_BUILD_SIZE for free with a Custom build, but that turns off the Provisioning options. |
Hmm sounds like we should add some proper checks in the N.B. there still should be a check that it can really only be included in a custom build (and thus not in a MAX build) or else we introduce a backdoor people may not be aware of. |
Thanks, will try this now |
Nope, still
|
Sorry, my bad, just realized that used the old syntax
|
Ah, yes, the fall-back for the old syntax is only included in the MAX builds... 😊 |
There is another confusion, though |
That's a security measure, to prevent accidental overwriting of your configuration |
Documentation on Provisioning |
Yes, just read it fully. Not completely intuitive, but should work as a security measure at least once :) Actually, I am not going to use it on a production scale at least until encryption is ready |
And firmware downloading seems too sensitive either for network delays or loop load, I got timeout on 5 out of 6 attempts without
|
Ah, I guess there's a little bit too much code there, it never gets to generating that event on a time-out... 🤔 (or a write-error, for the same reason) |
I have tested it on a few modules which were about 1000 km away, so definitely not "local". |
Yes, I think it should be done in a more relaxed state |
Concluding this session, for custom builds:
|
@chemmex Did you test the commit I linked? |
Yes, just have tested that unsuccsessful 404 FW update attempt
unsuccessful due to timeout
successful
It looks like only ProvisionFirmware#success event is generated, in all failure cases it goes silently. By the way, there is minor inconsistency between text and example in the docs: |
Ah good catch about the discrepancy between docs and actual failure event. Are you testing this on ESP8266? I thought I had the logs showing the strings for those errors. (at least on ESP32) |
No, that's ESP32-C3 |
Just found a time to test provisioning in its current state, but seems that all Provision commands are not recognized.
Have
FEATURE_SETTINGS_ARCHIVE
andDEFAULT_PROVISIONING_URL
defined in the Config.h, no more visible related settingsCan retreive the settings from the GUI, though
The text was updated successfully, but these errors were encountered: