Question: dropping grpc dependency from errors?

[jonjohnsonjr]

I'd like to pull in goodkey as a dependency, but this method ends up pulling in grpc. This method doesn't doesn't appear to be used in this repo, but presumably it's used elsewhere?

I see you are receptive to a similar change in #6651, but I don't see a clean non-breaking option in this case :/

Any thoughts on dropping/moving this method?

[jsha]

A related question: why does goodkey depend on berrors at all? Looks like it's just for this one line:

boulder/goodkey/good_key.go

Line 139 in 26adec0

return berrors.InternalServerError("error checking blocklist for key: %v", key)

But we don't need to explicitly return InternalServerError because a plain fmt.Errorf will get turned into an internal server error at the WFE layer. I suspect if you change that line to a fmt.Errorf you will find that goodkey no longer depends on berrors or gRPC. I'm pretty sure we would accept that as a PR.