grpc: Replace deprecated otelgrpc interceptors #7237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think filtering healthchecks isn't actually that important, so it would be fine to merge this and have a tracking bug to filter them later. We can always drop them in the collector, if we need. |
|
There's an open PR to add filtering, I'm inclined to let that play out and wait for a new otelgrpc version to be released. |
|
The upstream PR has been merged, but we need to wait for a new otelhttp release to be cut. The existing version bump #7467 has problems, so :|. |
|
#7467 has been merged, is this now ready to move forward again? Answer: No, the release we updated to doesn't contain the relevant PR. We still need to wait for the next release. |
|
Replaced by #7496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stay in draft mode until this upstream bug is fixed.
Fixes #7235