Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing progress report view for LEVANTE #30

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fixing progress report view for LEVANTE #30

merged 2 commits into from
Sep 16, 2024

Conversation

Zio-4
Copy link
Collaborator

@Zio-4 Zio-4 commented Sep 16, 2024

Proposed changes

Enables progress report view for LEVANTE. Hid some things like filtering columns, exporting the table, and switching views to score report since these do not work.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@Zio-4 Zio-4 marked this pull request as ready for review September 16, 2024 21:30
Copy link

github-actions bot commented Sep 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 1.19% 94 / 7850
🔵 Statements 1.13% 95 / 8358
🔵 Functions 0.68% 14 / 2056
🔵 Branches 0.54% 24 / 4397
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/CardAdministration.vue 0% 0% 0% 0% 168, 170-171, 173, 185-186, 188-221, 193-211, 198-206, 199-205, 209, 218, 223-227, 224-226, 225, 229-233, 230, 232, 235, 235-236, 236, 238-240, 239, 239, 242-244, 243, 247, 247, 250-251, 253-254, 256-261, 257-259, 258, 260, 263-268, 264-266, 265, 267, 270-273, 271-272, 275-277, 276, 279-285, 288-413, 289-292, 291, 291, 294-298, 296, 296, 300, 302, 304-327, 305-325, 317-325, 318-324, 326, 329, 329, 331-332, 332, 334, 336-338, 337, 340-342, 341, 344, 344-347, 346, 349-352, 354, 356-373, 358, 360, 360, 362-370, 375, 375-376, 378-395, 379-380, 380-394, 382-391, 383-388, 390, 393, 397-398, 398-399, 399, 401-410, 403-409, 404-408, 405, 405-406, 406-407, 412, 415-421, 417, 423-425, 424, 427-430, 429, 432-434, 433, 433, 436-519, 438-518, 439, 441, 441-442, 442, 444, 446, 450-456, 458-474, 460, 462, 462, 464-471, 476, 480-501, 482-498, 483-493, 488-490, 489, 491, 494, 496-498, 497, 500, 504-514, 505-513, 506-512, 507-511, 508, 508-509, 509-510, 516-517, 521-522, 524-535, 524-535, 537-558, 538-539, 541-542, 544-557, 560-565, 561-564, 562-563, 2, 7-9, 27, 29, 33, 97, 42
src/components/RoarDataTable.vue 0% 0% 0% 0% 685, 594-599, 597-598, 601, 620-621, 623-627, 624-626, 625, 625, 628-629, 631-647, 649-668, 652-666, 654-663, 665, 667, 670-672, 671, 674, 676-682, 677-680, 678-679, 681, 684, 688-694, 689-690, 692-693, 695, 699-708, 710-742, 711-740, 715-717, 716, 719-721, 724-726, 725, 729-732, 730-731, 734-739, 735-738, 741, 744-745, 747-750, 748-749, 752-766, 753-763, 765, 770-776, 773-775, 774, 777, 780-793, 795-808, 810-815, 817-828, 830-839, 841-872, 857-870, 866-869, 868, 871, 874-879, 877-878, 878, 881-886, 884-885, 885, 888-893, 891-892, 892, 895-899, 897-898, 898, 901-905, 903-904, 904, 907-911, 909-910, 910, 914-916, 915-916, 919-921, 920, 920, 923, 923-930, 925, 925-929, 927-928, 932-933, 935-938, 936-937, 940, 20, 34, 64-65, 116-118, 120, 134-136, 138, 152-154, 156, 170, 172, 176, 190, 192, 194, 208, 210, 212, 287, 300, 306, 317, 327, 338, 379, 398, 408, 418, 428, 438, 540-542, 54, 60, 73-74, 119, 137, 155, 175, 193, 211, 258, 266, 273, 281, 286, 291, 345, 519
src/pages/ProgressReport.vue 0% 0% 0% 0% 181, 183, 185, 200, 202-206, 208-213, 209-211, 210, 212, 215-217, 216, 219-232, 234-241, 235-240, 243-245, 248-254, 250, 255, 255-256, 256-257, 257, 259-266, 262, 268-277, 270, 275, 279-285, 281, 288-294, 290, 296, 296, 302-308, 304, 310-319, 311-318, 312-315, 313-314, 317, 321-396, 322, 322, 324, 326-393, 328, 330-334, 333, 337-349, 351-391, 354-355, 357-385, 358-385, 365-385, 372-377, 379-384, 386, 389, 392, 395, 398-401, 399-400, 403-425, 404-422, 405-414, 413, 415-417, 416, 418-420, 419, 421, 423-424, 427-454, 428-446, 429-438, 437, 439-441, 440, 442-444, 443, 445, 447-453, 456-546, 457, 457, 459-465, 467-479, 468-478, 469-477, 481-483, 482, 485-488, 486-487, 490-503, 491-494, 492-493, 495-502, 505-507, 506, 509, 509-516, 511-515, 512, 514, 518-519, 521-525, 522-524, 523, 527-531, 528-530, 529, 533-544, 534-543, 545, 548, 550-553, 552, 555-573, 556-572, 558-563, 560-562, 561, 564-568, 565-567, 566, 569, 571, 576-583, 578-579, 579, 581-582, 585-587, 586, 586, 589-591, 590, 590, 2-4, 6, 8-9, 14-15, 22, 38, 45-46, 69-73, 83, 125, 137, 140-141, 153, 24, 128, 144
Generated in workflow #22

Copy link

Visit the preview URL for this PR (updated for commit 9c54607):

https://hs-levante-admin-dev--pr30-fix-progress-report-49fnmubo.web.app

(expires Mon, 23 Sep 2024 22:13:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7889bff1da3bcc333d7422b9fc863c65b3962be7

@Zio-4 Zio-4 merged commit 961a872 into main Sep 16, 2024
4 of 5 checks passed
@Zio-4 Zio-4 deleted the fix-progress-report branch September 16, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant