Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey fixes for audio, progress, and translations #33

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

Zio-4
Copy link
Collaborator

@Zio-4 Zio-4 commented Oct 11, 2024

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 1.17% 94 / 8013
🔵 Statements 1.11% 95 / 8535
🔵 Functions 0.66% 14 / 2095
🔵 Branches 0.52% 24 / 4543
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/GameTabs.vue 0% 0% 0% 0% 137, 143-147, 149-153, 150, 150-151, 151-152, 155-186, 155-186, 156-157, 159-171, 160, 162-170, 164, 164, 166-167, 169, 174, 174, 176, 176-177, 177, 179-180, 180, 182-183, 185, 188, 190-201, 203-212, 214-231, 216, 218-225, 219-224, 220, 223, 227-229, 228, 230, 232-249, 234, 236-243, 237-242, 238, 241, 245-247, 246, 248, 251-264, 252, 254-263, 255-263, 260, 262, 266-268, 267, 270-276, 271-275, 272, 274, 278-284, 279-283, 280, 282, 286-293, 287-292, 289, 295-299, 296-298, 297, 301, 301-302, 302, 304, 309-315, 310-315, 312, 314, 317-329, 318-321, 323-325, 327-328, 332-345, 333-344, 28-32, 35, 43, 60-61, 73, 75, 87-88, 3, 98
src/components/LanguageSelector.vue 0% 0% 0% 0% 29, 32, 35, 35, 38, 40-48, 41-47, 42-46, 51, 53, 55-59, 56-58, 2, 14, 4
src/components/NavBar.vue 0% 0% 0% 0% 78-83, 86-89, 87, 87-88, 91-93, 92, 92, 95-98, 96, 96-97, 100-102, 101, 106-112, 108, 114-116, 115, 118-141, 119-139, 122-132, 123, 125-131, 129, 133-138, 134-137, 140, 143-146, 144-145, 148-165, 149-164, 150, 152-155, 154, 156-163, 160, 162, 167-171, 168, 168-169, 169-170, 173, 173, 175-177, 176, 179-185, 180-184, 187-202, 192, 199, 204-230, 205-229, 212, 219, 226, 232-234, 233, 3, 5, 9, 24, 26, 47
src/components/views/Settings.vue 0% 100% 100% 0% 16
src/helpers/survey.js 0% 0% 0% 0% 5, 8-24, 9-22, 13-21, 14-19, 18, 20, 23, 28, 32-33, 37-48, 39-41, 40, 42-45, 44, 47, 51-57, 52-56, 53-55, 61-81, 63-81, 69, 69-80, 71-76, 72, 74-75, 78-79, 85, 99, 101-156, 102, 105-106, 108, 110-117, 111-114, 116, 120-127, 130, 133-142, 134, 136-141, 144, 146, 148-155, 149-152, 154, 172-173, 175, 175, 178, 181-188, 190, 193-197, 194-196, 200, 203-237, 204-207, 210, 213-221, 214, 216-220, 217-220, 219, 223, 225, 227-228, 230-236
src/helpers/surveyInitialization.js 0% 0% 0% 0% 20-26, 29-32, 34-36, 39-41, 40, 43, 48-55, 57-66, 58-61, 60, 62-65, 63-64, 82-87, 84-87, 86, 90-105, 91-104, 108-122, 109-121
src/pages/AdminProfile.vue 0% 0% 0% 0% 65-68, 70-75, 71-74, 73, 77-79, 78, 84, 86-89, 87, 87-88, 91-93, 92, 92, 95-97, 96, 96, 99-105, 101, 108-112, 109, 109-110, 110-111, 5, 7-8, 12-13, 19-20, 24-25, 29-30, 49, 38
src/pages/HomeParticipant.vue 0% 0% 0% 0% 122-131, 134-138, 136, 136-137, 140-141, 143-145, 144, 144, 147-149, 148, 148, 151-152, 158-164, 160, 170-178, 172, 180, 180, 180-181, 181, 187-202, 190-198, 192-196, 204-206, 205, 205, 209, 211-212, 212, 214-286, 215-218, 220-228, 222-226, 223-225, 227, 230-232, 234-237, 239, 241-243, 245-265, 246-252, 249-251, 250, 254-260, 255-259, 256-258, 261-265, 262-264, 269-272, 271, 274-285, 275, 277, 277, 279-282, 284, 290-301, 297-298, 300, 304, 304, 304, 310-324, 313-319, 314-317, 327, 330-361, 333, 335-357, 336-357, 343-348, 351-356, 364-366, 365, 368, 368, 370-373, 371, 371-372, 376-377, 379-380, 384-389, 386-388, 393-490, 394, 394-395, 395, 397, 397, 399-422, 400-421, 401-403, 403, 405, 407, 409-420, 410-419, 410-411, 413, 413-418, 415, 417, 424-430, 425-430, 427-429, 428, 433-435, 438-458, 439-457, 440-450, 441-450, 452-454, 456, 460-461, 463-472, 474-486, 488, 492-500, 493, 495-499, 496, 498, 502-504, 503, 506-509, 507, 507-508, 511-515, 513-514, 519-571, 520-569, 521-545, 524-526, 531, 531-542, 547-566, 549-565, 550-556, 551-555, 552-554, 553, 557-565, 558-564, 559-563, 560-562, 561, 568, 570, 573-575, 574, 574, 577-579, 578, 578, 582-591, 583-590, 586, 594-596, 595, 599-601, 600, 600, 604-611, 605-607, 606, 608-610, 613-629, 616-618, 617, 619-620, 620, 623-626, 625, 12, 30-31, 50, 55, 70, 72, 18, 33-34, 43
src/pages/LEVANTE/UserSurvey.vue 0% 0% 0% 0% 13-16, 19-26, 20, 22-24, 23, 30-33, 32, 34-38, 41-43, 63
src/router/index.js 0% 0% 0% 0% 10, 10, 14, 14, 17-461, 21, 34, 40, 46, 53, 60, 67, 74, 81, 88, 95, 102, 109, 116, 123, 130, 137, 144, 151, 158, 165, 172, 179, 186, 193, 202, 209, 216, 223, 229-230, 235, 240, 248, 254, 269, 271-274, 273, 276-277, 279-280, 283-285, 287, 302-303, 310-311, 318, 324, 330, 336, 343, 349, 355, 361, 368, 375, 382, 389, 395, 397, 401, 407, 413, 419, 427, 433, 440, 446, 452, 458, 463-472, 467-468, 468-469, 469-470, 474-553, 476-480, 477, 479, 482, 484-492, 494, 496-502, 497-502, 500-501, 504-511, 509-510, 514-515, 518-519, 527-543, 528-543, 534-540, 535-540, 538-539, 541-542, 546-549, 547-548, 551-552
src/store/game.js 0% 100% 0% 0% 4-27, 5-26, 8-11, 15
src/store/survey.js 0% 100% 0% 0% 4-91, 5-90, 8-28, 32, 35, 38, 41-42, 45, 48, 51, 54, 57, 60, 64, 67, 70, 73, 76, 79
Generated in workflow #40 for commit 6c340c3 by the Vitest Coverage Report Action

Copy link

Visit the preview URL for this PR (updated for commit 6c340c3):

https://hs-levante-admin-dev--pr33-survey-fixes-v8m7qq76.web.app

(expires Fri, 18 Oct 2024 23:17:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7889bff1da3bcc333d7422b9fc863c65b3962be7

@Zio-4 Zio-4 merged commit 3ff29ac into main Oct 11, 2024
4 of 5 checks passed
@Zio-4 Zio-4 deleted the survey-fixes branch October 11, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant