Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adding jwt token validation #9

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

eknowlton
Copy link
Collaborator

  • Added JWT Token Authentication
  • JWT Auth disabled by default
  • Added Jwt section to config
    • Including JWT Secret for token validation

I at some point put the usage statistics per sub from the JWT token inside redis, with the number of API calls but that didn't seem like the right place. I can push that or do something else if you have a idea of where it would be more useful.

@eknowlton eknowlton marked this pull request as ready for review October 10, 2023 20:38
@eknowlton
Copy link
Collaborator Author

I added a singing key validation. Unfortunately I only did HMAC256|384|512 but I noticed the gem ruby-jwt supports more

The JWT spec supports NONE, HMAC, RSASSA, ECDSA and RSASSA-PSS algorithms for cryptographic signing. Currently the jwt gem supports NONE, HMAC, RSASSA and ECDSA

This could be more complicated if you want to add them too. Or remove it all together, or even make signing validation optional.

You're call.

@jacobhaug jacobhaug merged commit 72da6dc into master Oct 11, 2023
1 check passed
@eknowlton eknowlton deleted the feature/adding-jwt-token-validation branch November 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants