Make command log colorful #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two faces - one for keys and one for commands.
|
+1 good job |
|
@lewang did you see this? |
|
@bmag Could you resolve the conflict so that your change can be checked into this git repo so that spacemacs can use this repo instead of your custom repo? I took a shot and tried to resolve the conflict as shown below. (insert (propertize (format "%s" (if (byte-code-function-p cmd) "<bytecode>" cmd))
'face 'command-log-command)) |
|
@emacs18 your resolution looks correct to me. Is there anyone that will merge this PR if I resolve the conflict? |
pierre-rouleau
added a commit
to pierre-rouleau/command-log-mode
that referenced
this pull request
Nov 26, 2020
psionic-k
referenced
this pull request
in positron-solutions/command-log
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two faces - one for keys and one for commands.
You might want to adjust the faces' default values. They work fine with the theme I'm using, but not with the default emacs theme.
Implements #7