Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let there be no non-keyword target_link_libraries in the C target #42

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Let there be no non-keyword target_link_libraries in the C target #42

wants to merge 1 commit into from

Conversation

petervdonovan
Copy link
Contributor

This is due to an incompatibility between the two flavors of the API.
The modern flavor is preferred and required for compatibility with
Python libs, so I am sticking with that.

@petervdonovan
[build] No non-keyword target_link_libraries.
a75f08d 
This is due to an incompatibility between the two flavors of the API.
The modern flavor is preferred and required for compatibility with
Python libs, so I am sticking with that.
@petervdonovan petervdonovan changed the title Let there be no non-keyword target_link_libraries. Let there be no non-keyword target_link_libraries in the C target Aug 10, 2022
cmnrd
cmnrd reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be accompanied with a change in the C code generator. In the tests, cmake complains that we use a different style here than in the main cmake file. Is there already a PR in lingua-franca accompanying this?

@petervdonovan petervdonovan marked this pull request as draft September 7, 2022 17:28
@petervdonovan
Copy link
Contributor Author

Oops, you are right. The accompanying PR is lf-lang/lingua-franca#1299.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petervdonovan @cmnrd