Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the formatter to all benchmarks #64

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Apply the formatter to all benchmarks #64

merged 10 commits into from
Mar 11, 2024

Conversation

cmnrd
Copy link
Contributor

@cmnrd cmnrd commented Mar 8, 2024

This PR reformats all benchmarks. This needed some special care in order not to mess up the cog comments in the C benchmarks.

This is a first step towards fixing the benchmark tests in lf-lang/lingua-franca#2235.

@cmnrd cmnrd requested review from edwardalee and lhstrh March 8, 2024 17:22
@cmnrd cmnrd marked this pull request as ready for review March 11, 2024 10:40
@cmnrd
Copy link
Contributor Author

cmnrd commented Mar 11, 2024

@edwardalee @lhstrh This PR is ready to be merged now.

@edwardalee I removed the distributed C tests and hope that is Ok with you. I removed those files because they did not compile using the 0.6.0 lfc release (I did not investigate this), they are currently not integrated with the benchmark runner script, and they don't seem to be all that useful (PingPong is simply a copy of the non-federated PingPong and the TimeLimit has a rather narrow scope).

@edwardalee
Copy link
Contributor

Yes, removing these tests is ok with me.

@cmnrd cmnrd merged commit b5673a1 into main Mar 11, 2024
7 checks passed
@cmnrd cmnrd deleted the formatting branch March 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants