Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

Adjusted implementation of MessageReporter and new dependency on com.google.gson #55

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Adjusted implementation of MessageReporter and new dependency on com.google.gson #55

merged 9 commits into from
Nov 1, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Sep 30, 2023 •
edited
Loading

To accommodate changes in lf-lang/lingua-franca#2008.

@lhstrh
Copy link
Member Author

lhstrh commented Oct 30, 2023

@a-sr: there is another thing that needs to change in this PR. I introduced a new dependency (com.google.gson) but I'm not sure how to add the dependency in this code base. Would you be able to add it?

@lhstrh
Copy link
Member Author

lhstrh commented Oct 30, 2023

Also see https://github.com/lf-lang/lingua-franca/actions/runs/6685208664/job/18163271915 (lf-lang/lingua-franca#2008)

a-sr
a-sr approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do the trick.

@lhstrh lhstrh changed the title Adjusted implementation of MessageReporter Adjusted implementation of MessageReporter and new dependecy on com.google.gson Nov 1, 2023
@lhstrh lhstrh changed the title Adjusted implementation of MessageReporter and new dependecy on com.google.gson Adjusted implementation of MessageReporter and new dependency on com.google.gson Nov 1, 2023
@lhstrh lhstrh merged commit 681dba5 into main Nov 1, 2023
4 checks passed
@lhstrh lhstrh deleted the message-reporter branch November 1, 2023 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-sr a-sr a-sr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhstrh @a-sr