Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated APIs in C tests #2190

Merged
merged 20 commits into from
Feb 13, 2024
Merged

Replace use of deprecated APIs in C tests #2190

merged 20 commits into from
Feb 13, 2024

Conversation

edwardalee
Copy link
Collaborator

This PR is a companion to 353 in reactor-c, which removes deprecated API macros originally used in reaction bodies in the C target.

@edwardalee edwardalee marked this pull request as ready for review February 12, 2024 19:46
@edwardalee
Copy link
Collaborator Author

This PR is ready for review. There is a companion PR in reactor-c that requires a further companion review in the benchmarks repo in order to get all tests to pass.

Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@edwardalee edwardalee added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit af69dd7 Feb 13, 2024
49 of 61 checks passed
@edwardalee edwardalee deleted the cleanup-pass branch February 13, 2024 17:01
@lhstrh
Copy link
Member

lhstrh commented Feb 13, 2024

Looks like the right thing to do. It implies that the next version should be 1.0.0, not 0.7.0...

@edwardalee
Copy link
Collaborator Author

Yes, I'm also focused on a much-needed code cleanup pass. I could use some help figuring out how to get Doxygen to give a reasonable layout of the documentation web pages. The pages themselves are getting much better, but the layout is absurd.

@lhstrh
Copy link
Member

lhstrh commented Feb 13, 2024

@arengarajan99 worked on this a while ago but hit roadblocks because the code itself wasn't well organized. That situation has improved a lot since then, so I'm curious whether his attempt could be reinvigorated.

On the versioning: I think that we should plan a 1.0 version more carefully and release it only once we can confidently consider it stable... We can choose to strictly follow semantic versioning rules from v1.0 and on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants