Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more support for Python 3.9 #2312

Merged
merged 1 commit into from
Jun 5, 2024
Merged

No more support for Python 3.9 #2312

merged 1 commit into from
Jun 5, 2024

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jun 5, 2024 •
edited
Loading

This reverts commit 69c44d5.

Fixes #2310 and #2298.

This is not a real fix, however, because the issue due to the interaction between CMake and Python, not because of anything particular to Python 3.9.

@lhstrh lhstrh added the bugfix label Jun 5, 2024
@lhstrh lhstrh changed the title Revert "add support for no gil python" No more support for Python 3.9 Jun 5, 2024
@lhstrh lhstrh requested a review from edwardalee June 5, 2024 07:08
@lhstrh lhstrh enabled auto-merge June 5, 2024 07:09
edwardalee
edwardalee approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to merge this now to get the Python target working again, but we should open an issue that there needs to be a mechanism for a user to specify the Python version they wish to use. A target property? In any case, it should not be left up to CMake.

@lhstrh lhstrh added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 345df42 Jun 5, 2024
28 checks passed
@lhstrh lhstrh deleted the revert-python-3.9-support branch June 5, 2024 09:58
@lhstrh
Copy link
Member Author

lhstrh commented Jun 5, 2024

Issue already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue regarding target python
2 participants
@lhstrh @edwardalee