Fix for handling of target properties in imported files accessed through reactor class inheritance

[lhstrh]

Fixes #2286.

Summary by CodeRabbit

• New Features

  • Introduced ImportedCMakeInclude.lf to support importing and extending reactor definitions with a timeout mechanism.

• Improvements

  • Enhanced resource management by switching from List to Set, ensuring unique resources and improving efficiency in GeneratorBase and GeneratorUtils.

[coderabbitai]

Walkthrough

The recent changes improve the handling of resources within the GeneratorBase and GeneratorUtils classes by switching from List to Set data structures. This change helps in preventing duplicate entries, thus ensuring more efficient resource management. Additionally, a new method for managing inherited resources in reactors is introduced. A new test file is also added to verify these updates within a specific target.

Changes

File	Change Summary
core/.../GeneratorBase.java	Changed allResources from List to Set, updated method signatures to use Set instead of List.
core/.../GeneratorUtils.java	Replaced ArrayList with LinkedHashSet, switched methods to use Set instead of List, added addInheritedResources method.
test/C/.../ImportedCMakeInclude.lf	Introduced a new target file defining a reactor for testing the generation functionalities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GeneratorBase
    participant GeneratorUtils
    participant Reactor

    User->>GeneratorBase: Initiate resource processing
    GeneratorBase->>GeneratorUtils: Call getResources()
    GeneratorUtils->>GeneratorUtils: Fetch resources as Set
    GeneratorUtils-->>GeneratorBase: Return Set<Resource>
    GeneratorBase->>GeneratorUtils: Call transformConflictingConnectionsInModalReactors(Set<Resource>)
    GeneratorUtils->>GeneratorBase: Process resources
    GeneratorBase->>GeneratorUtils: Call addInheritedResources(Reactor, Set<Resource>)
    GeneratorUtils->>Reactor: Fetch inherited resources
    Reactor-->>GeneratorUtils: Return inherited resources
    GeneratorUtils-->>GeneratorBase: Updated resource Set
    GeneratorBase-->>User: Resource processing completed

Loading

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cmnrd]

Looks good!