Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unintended Action Override #2429

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix Unintended Action Override #2429

merged 1 commit into from
Oct 20, 2024

Conversation

Depetrol
Copy link
Collaborator

@Depetrol Depetrol commented Oct 17, 2024

This PR is the companion PR for lf-lang/reactor-c#491. It contains a fix in the code generator that is required for the change in reactor-c to pass the tests, and introduces a more aggressive test ConcurrentActionRepeat.lf that runs the ConcurrentAction.lf introduced in #2423 repeatedly to trigger another concurrency bug.

@Depetrol Depetrol marked this pull request as ready for review October 18, 2024 19:32
@Depetrol Depetrol requested a review from lhstrh October 18, 2024 21:01
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good to me, but I haven't looked closely at the reactor-c part of this...

@lhstrh lhstrh enabled auto-merge October 20, 2024 18:48
@lhstrh lhstrh added this pull request to the merge queue Oct 20, 2024
Merged via the queue into master with commit 8393142 Oct 20, 2024
24 checks passed
@lhstrh lhstrh deleted the fix-concurrency branch October 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants