Remove explicit depencency on ltest #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now a patch release must be made to this library every time there's a patch release of LFE. Relax that requirement so the latest patch and minor versions of LFE can be used.
|
Yeah, I think this is a good compromise. We can always cut a quick point release if this causes any unexpected problems :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ltest is only used in this one particular provider, so it makes sense to me that we remove the explicit dependency on it and instead rely on the user of the plugin to list ltest in their dependencies. This is technically a breaking change, however the templates already list ltest as a separate dependency so I think that should be OK. I also added a warning with what to do if you don't have it installed.
Supersedes #87