-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Django 5.x and Python 3.12 #17
base: master
Are you sure you want to change the base?
Conversation
Hi! Thanks for the PR, and acknowledging that I've seen this. My major concern is that this package is used by several other projects, at least one of which is still on python 2.7 (I know, I know), and it would be nice to keep it supported with the latest versions. Worse case scenario we can drop it, but let me fiddle with it for the next few days and see if I can have my cake and eat it too. Less seriously, I don't love the |
My thought would be that clients still on old versions of Python might have to restrict their version of this package to something like |
Clarification: inline annotations need to be syntactically valid Python (versions 3.5 and above depending on type annotation features). Annotations in |
Hi Lance,
Per our off-line discussion, here's a PR:
Regards,
Scott