Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory error #39

Closed
tomasbruna opened this issue Mar 31, 2023 · 5 comments
Closed

Memory error #39

tomasbruna opened this issue Mar 31, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@tomasbruna
Copy link

tomasbruna commented Mar 31, 2023

Dear Heng,

I encountered the following memory error when running miniprot:

$ miniprot genome.fasta problem.fa 
[M::[email protected]*1.01] read 74282399 bases in 1 contigs
[M::[email protected]*1.01] 580332 blocks
[M::[email protected]*1.82] collected syncmers
[M::[email protected]*1.73] 29640897 kmer-block pairs
[M::mp_idx_print_stat] 1899129 distinct k-mers; mean occ of infrequent k-mers: 15.61; 0 frequent k-mers accounting for 0 occurrences
[kfree] The end of a free block enters the allocated block.

I tested on both Mac and Linux, both give the same error. Here are the genome and the problematic protein: https://drive.google.com/drive/folders/1O40t8TUzFBvhdFI8ZFRZugcoiEA29Vlw?usp=sharing

Best,
Tomas

@lh3
Copy link
Owner

lh3 commented Mar 31, 2023

@KatharinaHoff reported another error on #38. Possibly related. I will find time to fix both. Thank you and @KatharinaHoff a lot for providing the examples.

@lh3 lh3 added the bug Something isn't working label Mar 31, 2023
lh3 added a commit that referenced this issue Apr 1, 2023
@lh3
Copy link
Owner

lh3 commented Apr 1, 2023

@KatharinaHoff and @tomasbruna: I believe I have fixed the bug. Once you can confirm on your side, I will cut a new release just for this fix. Thank you for the useful test cases.

@KatharinaHoff
Copy link

Dear Heng,
I confirm that my problem was fixed, no more segmentation fault on the data that I provided. Great! Thank you!
Best,
Katharina

@tomasbruna
Copy link
Author

I confirm as well, this fixed the issue for me. Thanks!

@lh3
Copy link
Owner

lh3 commented Apr 4, 2023

Thanks for the confirmation. I have just released v0.10 for this bugfix – segfault is always bad.

@lh3 lh3 closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants