-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write-host now sends output to hipchat in real-time #12
Open
mikeclayton
wants to merge
24
commits into
lholman:master
Choose a base branch
from
mikeclayton:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…output in hipchat during script execution so it can update processing status.
…through constructors
…gger part of constructor
…ient, added IChat* interfaces
…and BotEngine can just deal with threading.
…new Calculator 'agent' as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated AutoBotHost and PowerShellRunner so that using write-host in scripts results in the text being sent to HipChat there and then, rather than waiting for the script to finish running. This allows the script to report on progress for long-running tasks (although it might get a bit spammy if used too much).
Try this script to see the result:
function Get-WriteHostOutput {
write-host "starting up...";
for( $i = 1; $i -lt 10; $i++ )
{
write-host "test message $i";
[System.Threading.Thread]::Sleep(2000);
}
return "done!";
}
TODO: The PowerShellRunner class is becoming a bit of a dumping ground for the glue code so it might need to be cleaned up as a separate commit.