fix: account for when no good color can be found #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the color adjustment tool can't find a good color within the chosen color palette such that the contrast meets a ratio of 4.5:1. In those cases we fallback to using either white or black, whichever one yields the higher contrast.
Example:
Background:
#ffffffForeground:
#fffbb9Technically
#707070is sufficient here as a background, but the color adjust util does not seem to choose that. There may be opportunity for improvement here by modifying how the tool chooses colors. However, this fallback at least ensures adjusted colors meet the 4.5:1 contrast ratio.Interestingly, using
#ebebeb(slightly darker than white) as the background does not reproduce the issue.