Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pointer is not NULL before calling fclose() #28

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Ensure pointer is not NULL before calling fclose() #28

merged 3 commits into from
Dec 22, 2022

Conversation

jameskermode
Copy link
Member

Candidate fix for #27

@jameskermode jameskermode mentioned this pull request Dec 21, 2022
Closed
@jameskermode jameskermode linked an issue Dec 21, 2022 that may be closed by this pull request
Segfault when reading non-existent file #27
Closed
mfherbst
mfherbst reviewed Dec 22, 2022
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
@mfherbst
Copy link
Contributor

Yes this works. Now I get an error and no segfault

@jameskermode jameskermode merged commit 49f9496 into master Dec 22, 2022
@jameskermode jameskermode deleted the issue27 branch December 22, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfherbst mfherbst mfherbst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault when reading non-existent file
2 participants
@jameskermode @mfherbst