Update Bootstrap to v5.3.3 #2328
Conversation
style/bootstrap/ from https://github.com/twbs/bootstrap.git --branch v5.3.3 bootstrap.min.js from https://github.com/twbs/bootstrap/releases/download/v5.3.3/bootstrap-5.3.3-dist.zip
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| @@ -0,0 +1,42 @@ | |||
| // Responsive images (ensure images don't scale beyond their parents) | |||
| // | |||
| // This is purposefully opt-in via an explicit class rather than being the default for all `<img>`s. | |||
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
|
libsass refuse to compile this version of the Bootstrap. @Changaco I think Bootstrap 5 need Dart Sass. |
|
@iacore There's a Dart SASS package in PyPI. It's very heavy because it isn't optimized, but that could be fixed. |
|
Can you refactor current usage of sass to running the command |
|
I see no need to change how the SASS compiler is called. The difficulty is automating its installation, not calling it once it's installed. An automatic installation through PyPI is the best option from the point of view of a Liberapay developer. When a dependency isn't installed through PyPI, which is notably the case of PostgreSQL, it adds friction to the development and deployment of Liberapay. (I started working on getting rid of SQL last year, so I don't plan to work on automating the installation of PostgreSQL anymore.) |
I'm curious. Can you link to that work? |
|
Now the server returned |
Bootstrap tooltip need need bootstrap.bundle.min.js https://getbootstrap.com/docs/5.0/components/tooltips/
|
Now I don't see any JS error on page load. Hopefully tooltip is the only feature Liberapay uses from Bootstrap. Unfortunately this is as far as I can go without knowing anything about Bootstrap. You will have to fix the styles yourself. |
I'm not ready to push any code yet, but you can now find basic information in #2330, and ask further questions there if you want.
Bootstrap mostly provides classes that are added to HTML elements, so the migration mostly consists in replacing, in Liberapay's HTML code, obsolete Bootstrap v3 class names with new Bootstrap v5 class names. This is simple but long and not particularly interesting work, although someone who doesn't know Bootstrap could acquire a decent understanding of it and its history by working on this update. |
|
I had forgotten about it, but there was already a pull request for this: #1963. |
I don't want to learn bootstrap, sorry. Framework burn out is real. |
Closes #940.