iOS Test target #484
Merged
iOS Test target #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL-iOS is still a dependency of the libssh2-iOS target
Those that don't use GTFixtures
New submodule dependency through Carthage.
|
👍 Travis recently introduced longer build times on Mac machines (120 minutes). Maybe we can get public CI working again then? What do you think @joshaber? |
|
Sure, we can try Travis again if someone wants to set it up 👍 |
|
✋ I volunteer, progress tracked in #485 |
|
@phatblat if you resolve the merge conflicts and push again Travis will be started 😉 |
Closed
Specifying the destionation works around the following issue with xctool. Can also hard-code the architecture, but this seems more future-proof. ``` Failed to query the list of test cases in the test bundle: 2015-08-24 10:57:11.740 sim[50821:2746840] /Applications/Xcode6.4.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin/sim: No simulator devices appear to be running. Setting data directories to /var/empty. 2015-08-24 10:57:11.741 sim[50821:2746840] DYLD_INSERT_LIBRARIES contains possible bad values. Caller beware: /usr/local/Cellar/xctool/0.2.4/libexec/lib/otest-query-lib-ios.dylib dlopen(/Volumes/DerivedData/ObjectiveGitFramework-drtqacfhlqybdcdpqayztrrwneun/Build/Products/Debug-iphonesimulator/ObjectiveGit-iOSTests.xctest/ObjectiveGit-iOSTests, 1): Library not loaded: @rpath/ObjectiveGit.framework/ObjectiveGit Referenced from: /Volumes/DerivedData/ObjectiveGitFramework-drtqacfhlqybdcdpqayztrrwneun/Build/Products/Debug-iphonesimulator/ObjectiveGit-iOSTests.xctest/ObjectiveGit-iOSTests Reason: no suitable image found. Did find: /Volumes/DerivedData/ObjectiveGitFramework-drtqacfhlqybdcdpqayztrrwneun/Build/Products/Debug-iphonesimulator/ObjectiveGit.framework/ObjectiveGit: mach-o, but wrong architecture ``` Indeed, the "wrong architecture" message is correct as the framework was built for a different architecture than the test binary: ``` lipo -info ObjectiveGit.framework/ObjectiveGit ObjectiveGit-iOSTests.xctest/ObjectiveGit-iOSTests 2015-08-24 11:03 Non-fat file: ObjectiveGit.framework/ObjectiveGit is architecture: i386 Non-fat file: ObjectiveGit-iOSTests.xctest/ObjectiveGit-iOSTests is architecture: x86_64 ```
|
Another PR build is green! Ready for review. |
|
|
||
| BOOL success = [SSZipArchive unzipFileAtPath:zipPath toDestination:destinationPath overwrite:YES password:nil error:error]; | ||
|
|
||
| if (!success) { |
There was a problem hiding this comment.
Nit: it looks like there's a mix of tabs/spaces here.
|
Really fantastic work! Just a couple nits. |
|
Using SSZipArchive is almost an order of magnitude slower than shelling out to unzip:
I'm inclined to leave the Mac tests using unzip. I'd like to see the iOS tests run faster; perhaps once that's solved we could switch the Mac tests to use the same unzip mechanism. |
|
Wow, that's nuts! Thanks for doing the legwork on that. 🤘 |
tombooth
added a commit
to tombooth/objective-git
that referenced
this pull request
Feb 16, 2016
In libgit2#484 more flags were added into the variable `sdkflag`, which then caused the following execution of run_xctool to always fail. This means that iOS tests have not been running as part of the TravisCI run, they have only been built. You can see this if you look at the final run for the PR: https://travis-ci.org/libgit2/objective-git/builds/78334551#L192 Bash does some great things when trying to interpret variables in commands. Initially the `$sdkflag` didn't have any quotes around it as can be seen in commit 15f906c. When the second flag was added this would have caused the command to fail because of the way Bash would interpret the whitespace. Without the surrounding quotes the command would have been executed as follows: ``` xctool -workspace ObjectiveGitFramework.xcworkspace RUN_CLANG_STATIC_ANALYZER=NO -sdk iphonesimulator -destination '"platform=iOS' Simulator,name=iPhone '5"' -scheme "ObjectiveGit iOS" test ONLY_ACTIVE_ARCH=NO CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ``` You can see in the above that the white space was split in the middle of the `-destination` parameter and it causes `xctool` to spout out an error. When the surrounding quotes were added it caused xctool to run but `$sdkflag` would be interpretted as a single argument, as it is executed as follows: ``` xctool -workspace ObjectiveGitFramework.xcworkspace RUN_CLANG_STATIC_ANALYZER=NO '-sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 5"' -scheme "ObjectiveGit iOS" test ONLY_ACTIVE_ARCH=NO CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO ``` Notice in the above that the entire argument is still surrounded by single quotes. This can be solved by switching `$sdkflag` for an array of strings, this can then be correctly expanded in the command getting around the issues highlighted above. You can read more about these issues with Bash in the following links: - http://mywiki.wooledge.org/BashFAQ/050 - http://mywiki.wooledge.org/BashFAQ/073
This was referenced Feb 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS Tests #444
To help prevent things like #478 & #481.
Using SSZipArchive isn't ideal since it isn't a framework so the Xcode integration is ugly. But at least we can now run tests on iOS. Boy, are they slow. 💤