Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 7 + silence stupid warning #523

Merged
merged 8 commits into from
Oct 23, 2015
Merged

Xcode 7 + silence stupid warning #523

merged 8 commits into from
Oct 23, 2015

Conversation

joshaber
Copy link
Member

@joshaber joshaber commented Oct 5, 2015

Silences the warnings like:

<module-includes>:1:1: warning: umbrella header for module 'ObjectiveGit' does not include header blah blah blah blah

@joshaber
Copy link
Member Author

joshaber commented Oct 5, 2015

Carthage is really struggling with this for me:

A bunch of these:

Caught signal triggered by the Swift runtime!
Illegal instruction: 4

and then also:

*** Skipped building ZipArchive due to the error:
Dependency "ZipArchive" has no shared framework schemes

I'm not sure if these are Carthage bugs ... or ... computer bugs ...

@mdiep
Copy link
Contributor

mdiep commented Oct 5, 2015

I think you should be using --use-submodules --no-build, in which case you should never see that message.

@joshaber
Copy link
Member Author

joshaber commented Oct 5, 2015

Ohhhh right 👍

@phatblat
Copy link
Member

phatblat commented Oct 5, 2015

FYI, I've been dabbling on a real fix for those module warnings/errors in phatblat#1. The change is to build libgit2 as its own "git2" module instead of the "ObjectiveGit/git2" submodule that we're maintaining now. The result is git2.framework but I haven't gone as far as including OpenSSL and libssh2 yet.

@joshaber
Copy link
Member Author

joshaber commented Oct 5, 2015

That'll be ✨ if it works!

@phatblat
Copy link
Member

phatblat commented Oct 6, 2015

There are some other changes in #516 to get the build to work on Travis. Specifically, a newer version of xctool is necessary (e95cd59).

@joshaber
Copy link
Member Author

joshaber commented Oct 6, 2015

Indeed 😞

I opened facebookarchive/xctool#605 to see when they expect a new release.

@phatblat
Copy link
Member

phatblat commented Oct 6, 2015

Cool, thanks. I was starting to think we should just live with xctool at HEAD and open an issue to fix it later. If they can push out a release that will be even better.

@JrGoodle
Copy link
Contributor

@joshaber thanks for opening that issue, looks like it's coming "in a week or so" facebookarchive/xctool#605 (comment)

I've been keeping watch for the new release; I'll update #516 as soon as I see it's released

@joshaber
Copy link
Member Author

This is ready now 🙏

@mdiep
Copy link
Contributor

mdiep commented Oct 23, 2015

🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢

mdiep added a commit that referenced this pull request Oct 23, 2015
Xcode 7 + silence stupid warning
@mdiep mdiep merged commit 56d4e10 into master Oct 23, 2015
@mdiep mdiep deleted the xcode-7 branch October 23, 2015 15:24
@pietbrauer pietbrauer mentioned this pull request Dec 31, 2015
@phatblat phatblat mentioned this pull request Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants