Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updatePushURLString:error: to GTRemote #585

Merged
merged 2 commits into from
Jul 13, 2016

Conversation

Uncommon
Copy link
Contributor

@Uncommon Uncommon commented Jul 9, 2016

This is to match updateURLString:error:. There is a a setPushURLString: but it ignores errors.

At the moment I'm not able to run the tests (see #584) so I'm counting on Travis...

@pietbrauer pietbrauer mentioned this pull request Jul 11, 2016
@Uncommon
Copy link
Contributor Author

Having resolved #584, I have successfully run the tests.

@pietbrauer pietbrauer merged commit 7febb4f into libgit2:master Jul 13, 2016
@pietbrauer
Copy link
Member

Seems good, thanks! ✨

@Uncommon Uncommon deleted the updatepush branch January 5, 2017 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants