Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap git_index_add_all #628

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Wrap git_index_add_all #628

merged 2 commits into from
Jun 5, 2017

Conversation

alehed
Copy link
Contributor

@alehed alehed commented May 28, 2017

Allows the user to do something like git add -A

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good at a first glance. Could you add some simple tests for this? You could copy one of the existing ones, just add more than 1 file to it.

@alehed
Copy link
Contributor Author

alehed commented May 29, 2017

Sure, I just thought the test suite is ignored on this project.

@pietbrauer
Copy link
Member

I look at it. We "just" have one failing test on macOS which is consistent 😆. iOS is a different story.

@alehed
Copy link
Contributor Author

alehed commented May 29, 2017

Yeah, would be great if all the tests worked... But I do too see the value in testing.

I'll probably get around to the tests this weekend.

@pietbrauer
Copy link
Member

Yeah, many people have spent many hours trying to fix the tests. Thanks a lot! No pressure from my side 😅

@alehed
Copy link
Contributor Author

alehed commented May 29, 2017

#599 has a green iOS build, but it is already 5 months old.

@pietbrauer
Copy link
Member

@pietbrauer
Copy link
Member

Turns out it wasn't that hard. #631 has a green build. Thanks for pushing this @alehed!

@alehed
Copy link
Contributor Author

alehed commented May 29, 2017

@pietbrauer Thanks for fixing the build! 👍

@alehed
Copy link
Contributor Author

alehed commented Jun 4, 2017

I added a small test.

@pietbrauer pietbrauer merged commit 2279630 into libgit2:master Jun 5, 2017
@alehed alehed deleted the index_add_all branch June 6, 2017 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants