error C2275: 'PyObject' : illegal use of this type as an expression

[DK-at-FC]

Installing in Windows crashes in setup.py

python setup.py install
at Microsoft Visual Studio 9.0\VC\BIN\cl.exe ...
pygit2.c(496) : error C2275: 'PyObject' : illegal use of this type as an expression

Error is caused by variable declaration in the middle of the method in Repository_read;

Fix is to move the declaration to the beginning of the method

static PyObject *
Repository_read(Repository *self, PyObject *py_hex)
{
    git_oid oid;
    int err;
    git_odb_object *obj;
    size_t len;
    PyObject* tuple; // add declaration in line 487

...

    tuple = Py_BuildValue( // Remove tuple declaration in line 497

[jdavid]

Applied the change you have suggested. Close the issue if it works for you.

Thanks.

[DK-at-FC]

Great! Thanks David.

[damonchen]

windows platform could not compile for the same error in branch.c, I use vc compile with chinese locale, so information is:

src\branch.c(160) : error C2275: “PyObject”: 将此类型用作表达式非法

so how to compile with msvc vs2008

[jdavid]

Should be fixed, see #298