set remote callback before push #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| callbacks.update_tips = self._update_tips_cb | ||
| callbacks.credentials = self._credentials_cb | ||
| # We need to make sure that this handle stays alive | ||
| self._self_handle = ffi.new_handle(self) |
There was a problem hiding this comment.
self._self_handle needs to be set to None after the push operation completes, next to freeing the push object itself.
|
I've squashed the resource leak fix and pushed that to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the origin
remote.pushmethod will not work if the reposity need to be authorize, because no call back set, so i copy the set perfomance thefetchmethod do to thepush