Simple pipeline implementation. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veluca93
force-pushed
the
render-pipeline
branch
from
be4389c
to
618a991
Compare
|
The code is certainly missing at least a few tests, but given that the PR is large enough as it is I figured I'd have you take a look first ;) (and possibly split it up in more manageable commits if the overall approach seems sound) |
sboukortt
reviewed
Sep 30, 2024
veluca93
force-pushed
the
render-pipeline
branch
from
618a991
to
5b43340
Compare
tirr-c
reviewed
Sep 30, 2024
mo271
reviewed
Sep 30, 2024
mo271
approved these changes
Sep 30, 2024
Also add f64 to the possible image types, use an explicit enum to tag image types, and rework the pipeline interface.
veluca93
force-pushed
the
render-pipeline
branch
from
5b43340
to
bc2e0f8
Compare
I added tests for shrc, and I am wondering whether it would be best to put tests for the pipeline in another CL - ideally we'd want some more elaborate test infrastructure for all (both?) pipelines... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add f64 to the possible image types, use an explicit enum to tag image types, and rework the pipeline interface.