-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shared block support - libopenstorage extensions #2470
base: release-9.9
Are you sure you want to change the base?
Conversation
e86325d
to
25d6405
Compare
f521d58
to
eea8ca2
Compare
Signed-off-by: lsundararajan <[email protected]>
eea8ca2
to
ca857ac
Compare
// OptionsMigrateVolume control volume migration of shared raw block devices in kubevirt env for VMs | ||
// - Attach | ||
// This option indicates the next active coordinator node - machineID is expected | ||
OptionsMigrateVolume = "VOLUME_MIGRATE_TO_MACHINE" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the above change need to be part of this PR?
@@ -894,6 +907,9 @@ func (d *specHandler) SpecOptsFromString( | |||
if ok, fsFormatOptions := d.getVal(SpecFsFormatOptionsRegex, str); ok { | |||
opts[api.SpecFsFormatOptions] = fsFormatOptions | |||
} | |||
if ok, shared := d.getVal(sharedBlockRegex, str); ok { | |||
opts[api.SpecSharedBlock] = shared | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is spec_handler_test.go, can we add unit tests there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Just add a unit test case in spec-handelr_test.go and the migration option how it is relevant to current PR, is not very clear. I possible separate out adding of spec and migration related code into two different PR.s
What this PR does / why we need it:
Explain the PR and why it is needed.
Shared raw block extensions of libopenstorage - basic and necessary infra extensions only carved out of poc effort.
full poc here: https://github.com/pure-px/porx/pull/13673
Which issue(s) this PR fixes (optional)
PWX# https://purestorage.atlassian.net/browse/PWX-38767
Testing Notes
Add testing output or passing unit test output here.
Special notes for your reviewer:
Add any notes for the reviewer here.