Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-34294: storkctl need to parse https px endpoints properly, also need to assign default ports for http and https endpoints. #1537

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

diptiranjanpx
Copy link
Contributor

@diptiranjanpx diptiranjanpx commented Oct 17, 2023

Signed-Off-By: Diptiranjan

What type of PR is this?
bug

What this PR does / why we need it:

  1. Need to accept both https/http px endpoints.
  2. Need to provide default port as 80 or 443 with host names if not provided.

Does this PR change a user-facing CRD or CLI?:

Is a release note needed?:

Issue: https px endpoints were not working with storkctl create clusterpair.
User Impact: Migrations between clusters with ssl enabled px endpoints were not working.
Resolution: Both https and http endpoints with the scheme is now accepted as src-ep and dest-ep with storkctl create clusterpair.

Does this change need to be cherry-picked to a release branch?:

Test
Tested with

  1. https endpoints
  2. http endpoints
  3. Endpoints without port
  4. Endpoints without scheme
  5. Auto fetching endpoints
    Details have been added in PWX-34294

@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@diptiranjanpx diptiranjanpx force-pushed the PWX-34294 branch 2 times, most recently from bae6f24 to 5c60d77 Compare October 17, 2023 08:56
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (56aa1f2) 65.93% compared to head (a4b62b3) 66.09%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
+ Coverage   65.93%   66.09%   +0.15%     
==========================================
  Files          43       43              
  Lines        5349     5383      +34     
==========================================
+ Hits         3527     3558      +31     
- Misses       1490     1491       +1     
- Partials      332      334       +2     
Files Coverage Δ
pkg/storkctl/clusterpair.go 21.91% <61.36%> (+3.09%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/storkctl/clusterpair_test.go Outdated Show resolved Hide resolved
…eed to assign default ports for http and https endpoints.
@diptiranjanpx diptiranjanpx merged commit 70bdaec into master Oct 19, 2023
6 of 7 checks passed
@diptiranjanpx diptiranjanpx deleted the PWX-34294 branch May 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants