Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-34790: Enabling support for resourcetransformation for all objects including CRs. #1705

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

diptiranjanpx
Copy link
Contributor

Signed-off-by: Diptiranjan

What type of PR is this?
improvement

What this PR does / why we need it:
Now resourcetransformation is supported for CRs.

Does this PR change a user-facing CRD or CLI?:
no

Is a release note needed?:
yes

Issue: Resourcetransformation for CRs were not supported.
User Impact: It was blocking some of the necessary transformations for resources required in destination site.
Resolution: Now resourcetransformation for CRs is supported.

Does this change need to be cherry-picked to a release branch?:
yes, 24.2.0

Test:

  1. Transformed elasticsearch CR during migration.
  2. Checked resourcetransformation for an invalid resource.

Test results have been updated in the ticket.
The integration test will be raised in another PR.

@diptiranjanpx diptiranjanpx added enhancement unit-test The change adds or updates a unit test labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.90%. Comparing base (35be661) to head (e820222).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1705       +/-   ##
===========================================
- Coverage   67.41%   46.90%   -20.52%     
===========================================
  Files          43       47        +4     
  Lines        5905     8532     +2627     
===========================================
+ Hits         3981     4002       +21     
- Misses       1569     4174     +2605     
- Partials      355      356        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok.

@diptiranjanpx diptiranjanpx merged commit 964e228 into master Apr 12, 2024
4 of 5 checks passed
@diptiranjanpx diptiranjanpx deleted the PWX-34790 branch May 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement unit-test The change adds or updates a unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants