Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-6687 :: Handle restoring secured px volume #1733

Merged
merged 1 commit into from
May 3, 2024
Merged

PB-6687 :: Handle restoring secured px volume #1733

merged 1 commit into from
May 3, 2024

Conversation

vikasit12
Copy link
Contributor

@vikasit12 vikasit12 commented Apr 29, 2024 •
edited
Loading

What type of PR is this?

bug

What this PR does / why we need it:
This PR forces pxd driver to restore using driver.StartRestore irrespective of backuplocation type as we need to support secured portworx volume restore and the access token is known in stork.

Does this PR change a user-facing CRD or CLI?:
No

Is a release note needed?:
No

Does this change need to be cherry-picked to a release branch?:
release-24.1.0

Tests Screenshots:
Before Fix:
image

After Fix:
image
image
image
image

The extension of this fix and testing details of scenarios are covered in portworx/kdmp#360

@vikasit12 vikasit12 self-assigned this Apr 29, 2024
prashanthpx
prashanthpx approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@prashanthpx prashanthpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/applicationmanager/controllers/applicationrestore.go Show resolved Hide resolved
@vikasit12
PB-6687 :: Handle restoring secured px volume
25a40f2 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS

Signed-off-by: Vikas Kumar <[email protected]>
@pallav-px pallav-px merged commit 740d6a2 into master May 3, 2024
5 checks passed
olavangad-px pushed a commit that referenced this pull request May 3, 2024
@vikasit12 @olavangad-px
PB-6687 :: Handle restoring secured px volume (#1733)
37bc408 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS

Signed-off-by: Vikas Kumar <[email protected]>
olavangad-px pushed a commit that referenced this pull request May 3, 2024
@vikasit12 @olavangad-px
PB-6687 :: Handle restoring secured px volume (#1733)
a0e7d22 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS

Signed-off-by: Vikas Kumar <[email protected]>
pallav-px pushed a commit that referenced this pull request May 3, 2024
@vikasit12
PB-6687 :: Handle restoring secured px volume (#1733)
039695d 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS

Signed-off-by: Vikas Kumar <[email protected]>
vikasit12 added a commit that referenced this pull request May 6, 2024
@vikasit12
Revert "PB-6687 :: Handle restoring secured px volume (#1733)"
0fc3a04 
This reverts commit 740d6a2.
vikasit12 added a commit that referenced this pull request May 6, 2024
@vikasit12
Revert "PB-6687 :: Handle restoring secured px volume (#1733)"
9035cf0 
This reverts commit 039695d.
vikasit12 added a commit that referenced this pull request May 6, 2024
@vikasit12
Revert "PB-6687 :: Handle restoring secured px volume (#1733)"
8508a96 
This reverts commit a0e7d22.
@vikasit12 vikasit12 deleted the PB-6687 branch May 6, 2024 06:10
vikasit12 added a commit that referenced this pull request May 6, 2024
@vikasit12
PB-6687 :: Handle restoring secured px volume (#1733)
4ffc03a 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
vikasit12 added a commit that referenced this pull request May 6, 2024
@vikasit12
PB-6687 :: Handle restoring secured px volume (#1733)
f288919 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
vikasit12 added a commit that referenced this pull request May 6, 2024
@vikasit12
Revert "PB-6687 :: Handle restoring secured px volume (#1733)"
53dc966 
This reverts commit 740d6a2.
vikasit12 added a commit that referenced this pull request May 9, 2024
@vikasit12
PB-6687 :: Handle restoring secured px volume (#1733)
123f222 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
vikasit12 added a commit that referenced this pull request May 9, 2024
@vikasit12
PB-6687 :: Handle restoring secured px volume (#1733)
3a48ddb 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
vikasit12 added a commit that referenced this pull request May 9, 2024
@vikasit12
PB-6687 :: Handle restoring secured px volume (#1733)
9717139 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
siva-portworx pushed a commit that referenced this pull request May 10, 2024
@vikasit12 @siva-portworx
PB-6687 :: Handle restoring secured px volume (#1733)
6fdd37a 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS

Signed-off-by: Vikas Kumar <[email protected]>
siva-portworx pushed a commit that referenced this pull request May 10, 2024
@vikasit12 @siva-portworx
Revert "PB-6687 :: Handle restoring secured px volume (#1733)"
f44f024 
This reverts commit 740d6a2.
siva-portworx pushed a commit that referenced this pull request May 10, 2024
@vikasit12 @siva-portworx
PB-6687 :: Handle restoring secured px volume (#1733)
9df9ee9 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
shkumari-px pushed a commit that referenced this pull request May 13, 2024
@vikasit12 @shkumari-px
PB-6687 :: Handle restoring secured px volume (#1733)
35ab16a 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
siva-portworx pushed a commit that referenced this pull request May 13, 2024
@vikasit12 @siva-portworx
PB-6687 :: Handle restoring secured px volume (#1733)
2340238 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
shkumari-px pushed a commit that referenced this pull request May 24, 2024
@vikasit12 @shkumari-px
PB-6687 :: Handle restoring secured px volume (#1733)
28547a1 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
shkumari-px pushed a commit that referenced this pull request May 24, 2024
@vikasit12 @shkumari-px
PB-6687 :: Handle restoring secured px volume (#1733)
7bbe5e2 
-- Force portworx volume restore to stay away from restore via job even
if BL is NFS
-- Stop creating resourceExportCR for volumes if only pxdDriver is +nt

Signed-off-by: Vikas Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanthpx prashanthpx prashanthpx approved these changes

@siva-portworx siva-portworx Awaiting requested review from siva-portworx

@vsundarraj-px vsundarraj-px Awaiting requested review from vsundarraj-px

Assignees

@vikasit12 vikasit12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikasit12 @prashanthpx @pallav-px