-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post: rust-libp2p webrtc in the browser #117
Conversation
Feedback /additions / suggestions are welcome. As I am writing this, I'm realizing that the real news here is that rust-libp2p is running in the browser over WebRTC, so I'm making the distinction between server vs browser a lot. The repo has an example, so I'm torn whether to include any code examples there or just point people to the repo / docs. I'm leaning towards pointing, as rust docs are kept up to date through doctest so it'll always be more up to date whereas a blog entry will eventually fall out of date. So keeping more towards a news announcement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes me excited about the use-cases this enables.
Thank you for the work and sorry for the late review.
I think this still needs a couple of iterations. Here are some suggestions.
Sounds good to me! I'll hold off on a more detailed review for now to reduce the churn :) |
Thanks for touching base gentlemen! Yes it's a really rough draft right now but wanted to get a feel for your thoughts on the content. I'll have another look after libp2p day at Lab Week |
Co-authored-by: Max Inden <[email protected]>
Co-authored-by: Max Inden <[email protected]>
rm `the` typo Co-authored-by: Max Inden <[email protected]>
rm typo Co-authored-by: Max Inden <[email protected]>
Co-authored-by: Max Inden <[email protected]>
Co-authored-by: Max Inden <[email protected]>
I moved some paras around to make more sense, I capitalized Rust everywhere and made sme other small changes. Have a read!
Had another look at this today and made some changes. It is looking good and I think the right emphasis is starting to emerge. |
@DougAnderson444 ping us once you would like another review. Thank you for your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @DougAnderson444 ! I've left a few comments but overall looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited to see progress on #4389, connectivity between two browser tabs in libp2p-rust would be 🔥
It might be more beneficial to release this post than to keep editing it for perfection... if the reviewer likes the post, I recommend posting it. DA.
? |
Draft pull request for the blog post referenced in #113