Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Extract service implementation from go-libp2p-autonat #1

Merged
merged 8 commits into from
Oct 25, 2018
Merged

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Oct 16, 2018

@vyzo vyzo changed the title extract service implementation from go-libp2p-autonat Extract service implementation from go-libp2p-autonat Oct 16, 2018
@vyzo vyzo requested a review from Stebalien October 16, 2018 12:29
@vyzo vyzo self-assigned this Oct 16, 2018
@vyzo
Copy link
Contributor Author

vyzo commented Oct 18, 2018

we will need it for deployment, but it's not in the critical path yet.

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly shuffling around code that has already been reviewed. Just some typos on the docs.

README.md Outdated
@@ -0,0 +1,24 @@
# go-libp2p-discovery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# go-libp2p-discovery
# go-libp2p-autonat-svc

README.md Outdated

This package provides an implementation of the AutoNATService; see [autonat](https://github.com/libp2p/go-libp2p-autonat).

## Documenation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Documenation
## Documentation

@vyzo vyzo mentioned this pull request Oct 20, 2018
8 tasks
@vyzo vyzo added the blocked label Oct 20, 2018
@vyzo
Copy link
Contributor Author

vyzo commented Oct 20, 2018

We are blocked on merging, waiting for the changes in go-multiaddr-net to bubble up.

@vyzo vyzo mentioned this pull request Oct 20, 2018
@vyzo vyzo removed the blocked label Oct 25, 2018
@vyzo vyzo merged commit 1e10777 into master Oct 25, 2018
@vyzo vyzo deleted the implementation branch October 25, 2018 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants