This repository has been archived by the owner on May 11, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAT Auto Discovery #1
NAT Auto Discovery #1
Changes from 45 commits
32e8ab9
70f7dd8
f3d9a24
cc058d6
ef097b5
6efad8f
2aa66e5
ea43bf5
00fb7e7
0377627
7fad996
9af8715
bc41c7a
dcbcfce
9efd0ec
aaaa90e
1562e1b
6d4bc41
fa14117
d16ca79
b1733eb
bb5cad4
cd7a875
7b3981e
cf04a09
7c097ed
5837cc5
56a0966
54fb466
66ca387
3abf9c7
3b679e0
1cba297
dd7c7a9
9ff7df3
0fdf1b0
46d352f
0a4e215
91c209c
00d2fea
8ea9f1b
d9a0d1a
aadb8db
d7f55b0
852f4e0
9c8ee52
b2c65b0
8d2e2ae
9ef3734
6a3a9cb
67bccae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about "no nat"? Do we need that state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does that state mean though? We have Uknown and Public -- no nat is equivalent to public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was thinking:
(although we may not need to track the undialable case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more of "dialable" or not "dialable".
Do we gain anything by knowing that there is no NAT whatsoever?
Note that the inference might be hard to make.