This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
simplify generation of reservations #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jul 8, 2021
marten-seemann
force-pushed
the
simplify-handle-reserve
branch
from
2a0c38e
to
958f509
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for this difficult to reason about rollback procedure. Difficult because it happens after the mutex is unlocked, so other Go routines might already have modified the maps.
Really, the only reason why writing the response would fail is that the stream was closed / reset by the peer. In that case the reservation would not be received by the peer. However, this can also happen for a number of other reasons, e.g. when the stream is reset after the response was written, if the peer disconnects before reading the message, and many others.