dht query improvements #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
(this is a WIP as in, i'm still looking at other change to make to the query code. These changes by themselves are really ready to go) |
Stebalien
approved these changes
Jun 6, 2018
bigs
suggested changes
Jun 6, 2018
| @@ -38,7 +39,8 @@ type dhtQueryResult struct { | |||
| closerPeers []*pstore.PeerInfo // * | |||
| success bool | |||
|
|
|||
| finalSet *pset.PeerSet | |||
| finalSet *pset.PeerSet | |||
There was a problem hiding this comment.
hrm? This is go fmt'ed
query.go
Outdated
| @@ -236,7 +241,7 @@ func (r *dhtQueryRunner) queryPeer(proc process.Process, p peer.ID) { | |||
|
|
|||
| // make sure we're connected to the peer. | |||
| // FIXME abstract away into the network layer | |||
| if conns := r.query.dht.host.Network().ConnsToPeer(p); len(conns) == 0 { | |||
| if r.query.dht.host.Network().Connectedness(p) == inet.NotConnected { | |||
There was a problem hiding this comment.
maybe add a comment to the effect of "failure to establish a connection will cause the function to short circuit in this block" to make the function flow read easier
whyrusleeping
force-pushed
the
feat/query-improvements
branch
from
9d83941
to
6b33279
Compare
bigs
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a WIP, but these two changes should be pretty good on their own.
The first is relatively minor, and just uses a more optimal method for checking if we have a connection to a peer.
The second one changes
GetClosestPeersto only return the peers from its query that it was actually able to connect to. This is strictly better than the current code, as currently we return a set of peers that we are either already connected to (and the query knows this) or we have already failed to dial them (and the query knows this). Where the end result is we basically fail to put records to the peers that the query has already failed to connect to. So theres really no point in returning these peers to the caller, as we just tried and failed to connect to them.