-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter unworkable peers in queries + enhanced logging #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
changed the title
initial stab at filtering peers in queries
filter unworkable peers in queries
Jun 26, 2019
raulk
changed the title
filter unworkable peers in queries
filter unworkable peers in queries + enhanced logging
Jun 26, 2019
We need to put/get to a consistent set of peers. This current patch doesn't do that. It may work in practice because, unless we're entirely offline, we're only likely to find at most one "closest peer" on the local network (out of K=20) but it's still incorrect and this at least needs to be documented somewhere. We could also:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The critical contribution of this PR is preventing adding useless peers to our queries. The definition of useless is:
Secondly it also adds outbound filtering so that upgraded nodes will contextualise the peers they send back, based on whether the connection with the requester is via LAN or not.