Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specified CODEOWNERS #828

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Specified CODEOWNERS #828

merged 3 commits into from
Apr 6, 2023

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Mar 13, 2023 •
edited
Loading

I tried to split code ownership between go-libp2p and kubo maintainers. Please let me know your thoughts

#825

@guillaumemichel guillaumemichel self-assigned this Mar 13, 2023
@guillaumemichel guillaumemichel mentioned this pull request Mar 13, 2023
Closed
@guillaumemichel
Copy link
Contributor Author

The CODEOWNER file seems not to accept @ipfs/kubo-maintainers.

kubo-maintainers

I wasn't able to give write permissions to @ipfs/kubo-maintainers.

kubo-maintainers2

Is it possible to give write permissions to a team from a different org?

cc: @BigLep @galargh

guseggert
guseggert reviewed Mar 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@guseggert
Copy link
Contributor

LGTM just need to fix the team somehow, after that I'll approve

@galargh
Copy link
Contributor

galargh commented Mar 24, 2023

Is it possible to give write permissions to a team from a different org?

Nope, but we can create kubo-maintainers team in this org too. You can copy https://github.com/ipfs/github-mgmt/blob/d8bfce1a65dfcc34ba5f780b9aaaf5c68916d2cc/github/ipfs.yml#L6020 to https://github.com/libp2p/github-mgmt/blob/27021f542d76f1493c5ae1102a80844e153113fc/github/libp2p.yml#L4798

@guillaumemichel guillaumemichel mentioned this pull request Mar 24, 2023
Merged
4 tasks
@guillaumemichel
Copy link
Contributor Author

It would be great to have the approval of @MarcoPolo or @marten-seemann before we merge

MarcoPolo
MarcoPolo approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@guillaumemichel guillaumemichel merged commit f291c9c into master Apr 6, 2023
@guillaumemichel guillaumemichel deleted the gui/add-codeowners branch April 6, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@guseggert guseggert guseggert approved these changes

@BigLep BigLep Awaiting requested review from BigLep

@marten-seemann marten-seemann Awaiting requested review from marten-seemann

@Jorropo Jorropo Awaiting requested review from Jorropo

Assignees

@guillaumemichel guillaumemichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guillaumemichel @guseggert @galargh @MarcoPolo