fixed kbucket bug :) #117
Merged
fixed kbucket bug :) #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JamesHertz for spotting this bug! I edited your fix, so that the new peer gets added to the bucket before the replaceable one gets evicted, so that the bucket doesn't get removed. Does it look good to you? |
guillaumemichel
approved these changes
May 16, 2023
|
Yes it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added a test called TestBugFinder which fails because when adding a new peer to a bucket in which another peer will be evicted to make space for the new one (having the bucketsize = 1), the code just doesn't take into account that the bucket where the new peer info is going to be added may be deleted from the routing table.
I just added lines that take care of it. I know the test is very specific and that the probability of the bucketsize being equals to 1 is very little, but when someone uses the code she/he usually assumes it will work just fine.