Simplify Filter Whitelisting #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
commented
Jun 10, 2020
| @@ -185,29 +174,11 @@ func (f *Filter) TryAdd(p peer.ID) bool { | |||
| return false | |||
| } | |||
| if len(key) == 0 { | |||
| dfLog.Errorw("group key is empty", "appKey", f.logKey, "ip", ip.String(), "peer", p) | |||
| dfLog.Debugw("group key is empty", "appKey", f.logKey, "ip", ip.String(), "peer", p) | |||
There was a problem hiding this comment.
@aschmahmann This is intentional as it causes needless noise in the logs.
aschmahmann
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aschmahmann
I've found bugs in the query diversity logic wherein a whitelisted peer can later be rejected by the Filter simply because we don't have an ASN for it's IPV6 address etc etc.
Part of the reason these bugs exist is the filter is hard to reason about. This is one step towards simplifying it.